-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Windows DLL load issues related to PyInstaller #377
Conversation
for more information, see https://pre-commit.ci
@phx-mkoninckx could you give it a try to the executable that gets generated from the workflow? We are resetting the DLL loading as suggested in the PyInstaller documentation now. Also took the opportunity to revert the hack we implemented for the paths. |
(Linux failing build is expected and under investigation by @tusharbana-ansys) |
This does seem to resolve the specific issue I was looking at when I reported #376. However, I'm concerned about the revert of #344. The fix in #344 did actually have some impact; without it,
Overall, this is less concerning than the impact of calling
However, if #344 was really the fix for #343, then reverting it could cause #343 to regress? |
This reverts commit c0b8194.
Good point @phx-mkoninckx - I just checked it with the dev version and saw it was no longer in the PATH, buuut... that is not true if you used the full solution (executable on workflow). Reapplying the change. Thanks a lot for all the explanations @phx-mkoninckx!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! @RobPasMue -- with respect to the changes to PATH
, I start to wonder if what might be better than trying to undo the addition of the _internal
directory would either be to:
a) attempt to directly read and use the registry key that Windows would use to set the environment of a newly-started command prompt for the PATH
specifically -- i.e. what is set in the Control Panel for that environment variable
b) more generally look into ways to launch processes from Python such that they don't inherit the environment from the Python interpreter process but instead emulate the behavior of them being launched by the user from the Windows shell (i.e. explorer.exe
; the initial environment is based on the Control Panel settings for environment variables). But that would be a separate PR / issue
Let's do that on a follow up PR - merging! |
Closes #376